update vendor #138
Merged
update vendor #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @EagleChen I find that we can't pass CI now, see https://travis-ci.org/siddontang/go-mysql-elasticsearch/jobs/278188321 But I have tested on my local computer with ES 5.5, ES 5.6, both work fine, so I have no idea what is wrong now. Can you help me? |
|
OK, I'll run some tests locally and see if I can find out what's wrong. |
|
it works on my computer... (es: 5.5.0) Maybe the failure is related to travis CI environment. I'll try to figure it out later. |
|
Thank you @EagleChen Maybe we should use a special ES version in travis CI. |
siddontang
force-pushed
the
siddontang/update-vendor
branch
from
5bc44ed to
b13a1c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.